Module:BiomeDetails: Difference between revisions

[checked revision]

Latest revision as of 11:36, 7 May 2024

local p = {}

local Utils = require('Module:Utils')

function p.listBiomes(frame)
    local args = Utils.normaliseArgs(frame)
    return p.renderBiomeList(args.type)
end

function p.renderBiomeList(biomeType, includeSubBiomes)
    local biomeData = require("Module:BiomeData")
    ---@type boolean
    local isLand
    if biomeType == 'Land' then
        isLand = true
    elseif biomeType == 'Water' then
        isLand = false
    end

    local biomes = {}
    for _, biome in pairs(biomeData) do
        if biome.Name ~= '' and (isLand == nil or biome.Land == isLand) and (includeSubBiomes ~= true or biome.MainBiome == '') then
            biomes[#biomes + 1] = "* [[" .. biome.Name .. "]]"
        end
    end
    table.sort(biomes)

    return table.concat(biomes, "\n")
end

return p

@@ Line 19: / Line 19: @@
      local biomes = {}
-    local biome_keys = {}
      for _, biome in pairs(biomeData) do
          if biome.Name ~= '' and (isLand == nil or biome.Land == isLand) and (includeSubBiomes ~= true or biome.MainBiome == '') then
-             if biome.MainBiome == '' then
+             biomes[#biomes + 1] = "* [[" .. biome.Name .. "]]"
-                biome_keys[#biome_keys + 1] = biome.ID
-                if biomes[biome.ID] == nil then
-                    biomes[biome.ID] = { Name = biome.Name, SubBiomes = {} }
-                else
-                    biomes[biome.ID]["Name"] = biome.Name
-                end
-            else
-                if biomes[biome.MainBiome] == nil then
-                    biomes[biome.MainBiome] = { Name = biome.Name, SubBiomes = {} }
-                end
-                biomes[biome.MainBiome]["SubBiomes"][#biomes[biome.MainBiome]["SubBiomes"] + 1] = biome.Name
-            end
          end
      end
-     table.sort(biome_keys)
+     table.sort(biomes)
-    local biome_list = {}
+     return table.concat(biomes, "\n")
-    for _, biome_id in ipairs(biome_keys) do
-        local biome = biomes[biome_id]
-        biome_list[#biome_list + 1] = "* [[" .. biome.Name .. "]]"
-        for _, sname in pairs(biome["SubBiomes"]) do
-            biome_list[#biome_list + 1] = "** [[" .. sname .. "]]"
-        end
-    end
-     return table.concat(biome_list, "\n")
 end
 return p